Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated token-program.md course #492

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

updated token-program.md course #492

wants to merge 3 commits into from

Conversation

Ozodimgba
Copy link

Problem

Some of the methods used in the @solana/spl-token package in this course have been updated and might cause confusion for learners interacting with the package presently

Summary of Changes

  • createMint now uses createInitializeMint2Instruction,
  • createAssociatedTokenAccount method replaced asynchronous getAssociatedTokenAddress calls with synchronous getAssociatedTokenAddressSync to make sure token account is only created when none exists
  • allowOwnerOffCurve parameter is a necessary parameter for certain use case like vaults and interactions with multi sig wallets. see the @solana/spl-token commit here

mikemaccana
mikemaccana suggested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also please update this lesson to import the specific functions used from web3.js and spl-token, rather than using import * as token? This will match the other lessons.

@Ozodimgba
Copy link
Author

Fixed up chief. Updated this course for the Superteam bounty but review is coming after. Am I still eligible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemaccana mikemaccana mikemaccana requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ozodimgba @mikemaccana